Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge branch Davi0kProgramsThings:v3.0.0b3 into branch bitfinexcom:master. #228

Merged
merged 65 commits into from
Nov 23, 2023
Merged

Merge branch Davi0kProgramsThings:v3.0.0b3 into branch bitfinexcom:master. #228

merged 65 commits into from
Nov 23, 2023

Conversation

Davi0kProgramsThings
Copy link
Contributor

PR merges new beta version 3.0.0b3.
This version is a huge improvement over bitfinex-api-py v3.0.0b2.
All bitfinex-api-py v3-beta's users should upgrade their projects.

v3.0.0b3 introduces:

  • type hinting support for all API's components.
  • a faster, lighter and more secure websocket client.
  • several bug fixes for both http and wss interfaces.
  • ...and much more!

DISCLAIMER:
Production use of v3.0.0b3 (and all future beta versions) is HIGHLY discouraged.
Beta versions should not be used in applications which require user authentication.
Provide your API-KEY/API-SECRET, and manage your account and funds at your own risk.

@Davi0kProgramsThings
Improve and rewrite bfxapi.websocket.subscriptions.
59a0dca
@Davi0kProgramsThings
Rename bfxapi.websocket.handlers.authenticated_events_handler to auth…
57680ab 
…_events_handler (AuthenticatedEventsHandler -> AuthEventsHandler).
@Davi0kProgramsThings
Upgrade to Mypy 1.3.0 (old: 0.991). Fix compatibility problems with M…
c8290f1 
…ypy. Add type hints to bfxapi.websocket.handlers.
@Davi0kProgramsThings
Add type hints and type checks in bfxapi.websocket.client.bfx_websock…
dbc61ab 
…et_inputs.
@Davi0kProgramsThings
Improve JSONEncoder class in bfxapi.utils.json_encoder.
bc0f83d
@Davi0kProgramsThings
Remove support for datetime type and improve typing in several files.
7059846
@Davi0kProgramsThings
Add new event liquidation_feed_update to PublicChannelsHandler (and i…
708fdc8 
…mprove overall type hinting).
@Davi0kProgramsThings
Fix comment on top of examples in both examples.rest.auth and example…
f343fce 
…s.websocket.auth.
@Davi0kProgramsThings
Rename RestAuthenticatedEndpoints to RestAuthEndpoints (and bfxapi.re…
d63c2c6 
…st.endpoints.rest_authenticated_endpoints to rest_auth_endpoints).
@Davi0kProgramsThings
Remove type hinting for decorators _require_websocket_connection and …
cc5f9f5 
…_require_websocket_authentication.
@Davi0kProgramsThings
Replace use of asyncio.locks.Event with asyncio.locks.Condition in bf…
b12fedb 
…x_websocket_bucket.py.
@Davi0kProgramsThings
Change visibility of decorators require_websocket_connection and requ…
d9733e8 
…ire_websocket_authentication (and hardcode HEARTBEAT).
@Davi0kProgramsThings
Remove support for BfxWebSocketClient's instance variable events_for_…
fc84389 
…subscription.
@Davi0kProgramsThings
Rename bfxapi.websocket.client to _client and bfxapi.websocket.handle…
1d911a2 
…rs to _handlers (according to PEP8).
@Davi0kProgramsThings
Add sub-package bfxapi.websocket._event_emitter (with bfx_event_emitt…
080ec40 
…er.py).
@Davi0kProgramsThings
Add type hinting support to bfxapi.websocket.client.bfx_websocket_buc…
8b196b8 
…ket.
@Davi0kProgramsThings
Add type hinting support to bfxapi.websocket.client.bfx_websocket_cli…
f1e678e 
…ent.
@Davi0kProgramsThings
Rename bfxapi.utils to _utils (and update references).
9edbd7a
@Davi0kProgramsThings
Improve wss_timeout implementation in BfxWebSocketClient.
bae48b2
@Davi0kProgramsThings
Improve bfxapi._utils.logger (and update usage in Client).
755ee76
@Davi0kProgramsThings
Add and implement new IncompleteCredentialError in bfxapi.client.
faffb7f
@Davi0kProgramsThings
Rename bfxapi._utils.logger to bfxapi._utils.logging (and update refe…
4ba6b28 
…rences).
@Davi0kProgramsThings
Fix missing return statement in public_channels_handler.__raw_book_ch…
da2b411 
…annel_handler.
@Davi0kProgramsThings
Add fix to handle InvalidStatusCode exception (for 408 Request Timeout).
3038027
@Davi0kProgramsThings
Add config to enable checksums in BfxWebSocketBucket.
d9267de
@Davi0kProgramsThings
Add event handler for checksum messages (PublicChannelsHandler).
3c02232
@Davi0kProgramsThings
Block negative checksums for possible race condition (PublicChannelsH…
ce23a89 
…andler::__checksum_handler).
@Davi0kProgramsThings
Fix bug in method BfxWebSocketBucket::unsubscribe.
26f25e5
@Davi0kProgramsThings
Add implementation for BfxWebSocketClient::resubscribe and BfxWebSock…
f39b054 
…etBucket::resubscribe.
@Davi0kProgramsThings
Add order book checksum handling in /examples/websocket/public/order_…
3a06b22 
…book.py.
@Davi0kProgramsThings
Fix type hinting in module bfxapi._utils.json_encoder.
9872adf
@Davi0kProgramsThings
Add new module bfxapi._utils.json_decoder.
de0ee54
@Davi0kProgramsThings
Fix and rewrite some logic in class BfxWebSocketClient.
25881e7
@Davi0kProgramsThings
Fix small bug in module bfxapi.exceptions.
378e89b
@Davi0kProgramsThings
Rewrite all logic regarding connection multiplexing.
122d692
@Davi0kProgramsThings
Add pause/resume logic in class BfxWebSocketClient.
374b632
@Davi0kProgramsThings
Remove wss-event event from BfxWebSocketClient and BfxWebSocketBucket.
e5ec94b
@Davi0kProgramsThings
Add automatic deletion for buckets that reach zero subscriptions (e.g…
133db74 
…. after a call to BfxWebSocketClient::unsubscribe).
@Davi0kProgramsThings
Apply some refactoring to sub-package bfxapi.websocket.
ddce83b
@Davi0kProgramsThings
Fix and rewrite module bfx_websocket_inputs in bfxapi.websocket._client.
ac50f8f
@Davi0kProgramsThings
Improve fidelity to pylint's standard rules.
8e915e4
@Davi0kProgramsThings
Drop modules bfxapi.enums, bfxapi.rest.enums and bfxapi.websocket.enums.
2734ff9
@Davi0kProgramsThings
Fix bug in module bfxapi.websocket._event_emitter.
c02d6d7
@Davi0kProgramsThings
Remove useless and redundant docstrings from custom exceptions.
b082891
@Davi0kProgramsThings
Remove old test suite in module bfxapi.tests.
77494de
@Davi0kProgramsThings
Apply small changes to .github/ISSUE_TEMPLATE.md and .github/PULL_REQ…
36c48c3 
…UEST_TEMPLATE.md.
@Davi0kProgramsThings
Upgrade dependencies in requirements.txt and dev-requirements.txt.
1e7a4d5
@Davi0kProgramsThings
Fix bug in cancel_order_multi (both rest and websocket).
2bed2f6
@Davi0kProgramsThings
Rename property 'renew' to 'op_renew' in get_deposit_address.
8c65ba5
@Davi0kProgramsThings
Fix several bugs in sub-package bfxapi.rest.endpoints.
9287723
@Davi0kProgramsThings
Rewrite all rest examples according to v3.0.0b3's changes.
1ec6c49
@Davi0kProgramsThings
Rewrite all websocket examples according to v3.0.0b3's changes.
1accf92
@Davi0kProgramsThings
Fix bug in BfxWebSocketClient::on's arguments (bfxapi/websocket/_clie…
5e50aa6 
…nt/bfx_websocket_client.py).
@Davi0kProgramsThings
Add 'checksum' event in sub-package bfxapi.websocket._event_emitter.
f3fe14b
@Davi0kProgramsThings
Add support for Python 3.11 (edit setup.py).
afca5e3
@Davi0kProgramsThings
Bump __version__ in file bfxapi/_version.py to v3.0.0b3.
f63224c
itsdeka
itsdeka approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@itsdeka itsdeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @Davi0kProgramsThings
LGTM

@Davi0kProgramsThings
Copy link
Contributor Author

Thank you @itsdeka 😁!

@vigan-abd vigan-abd merged commit 90bba4e into bitfinexcom:master Nov 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsdeka itsdeka itsdeka approved these changes

@vigan-abd vigan-abd vigan-abd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Davi0kProgramsThings @vigan-abd @itsdeka