Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused public colls conf accessors to use common one #404

Merged
merged 22 commits into from
Aug 8, 2024
Merged

Remove unused public colls conf accessors to use common one #404

merged 22 commits into from
Aug 8, 2024

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Aug 7, 2024

This PR removes unused public colls conf accessor endpoints to use the common getAllPublicCollsConfs/editAllPublicCollsConfs one without breaking the logic and UI functionality

Basic changes:

  • remove unused candles, public trades, tickers history, status messages conf accessor endpoints
  • remove redundant test coverage and adapt to use editAllPublicCollsConfs endpoint
  • move public collection config names to constants in a separate file

ZIMkaRU added 22 commits August 6, 2024 08:04
@ZIMkaRU
Remove unused candles conf accessors
2be572e
@ZIMkaRU
Remove unused public trades conf accessors
8fd5efd
@ZIMkaRU
Remove unused tickers history conf accessors
444f2a3
@ZIMkaRU
Remove unused status messages conf accessors
718b0a8
@ZIMkaRU
Add candles coll conf name to constant
49b62a2
@ZIMkaRU
Add public coll conf name constants di type
142e345
@ZIMkaRU
Add public coll conf name constants to di
28e088f
@ZIMkaRU
Use public coll conf names in candles sync schema
4a7c07d
@ZIMkaRU
Use public coll conf names in main service
f5ef19f
@ZIMkaRU
Use public coll conf names in PublicCollsConfAccessors service
b0c02f2
@ZIMkaRU
Add statusMessages coll conf name to constant
0c38117
@ZIMkaRU
Use public coll conf names in statusMessages sync scheme
45188ae
@ZIMkaRU
Use statusMessages coll conf name in main service
af1a7fa
@ZIMkaRU
Use statusMessages coll conf name in PublicCollsConfAccessors service
4208425
@ZIMkaRU
Add tickersHistoryConf coll conf name to constant
e3cf74e
@ZIMkaRU
Use public coll conf names in tickersHistoryConf sync scheme
52954b4
@ZIMkaRU
Use tickersHistoryConf coll conf name in main service
a12c53b
@ZIMkaRU
Use tickersHistoryConf coll conf name in PublicCollsConfAccessors ser…
8b8b76d 
…vice
@ZIMkaRU
Add publicTradesConf coll conf name to constant
9f4f69c
@ZIMkaRU
Use public coll conf names in publicTradesConf sync scheme
4d5ab81
@ZIMkaRU
Use publicTradesConf coll conf name in main service
0ed8398
@ZIMkaRU
Use publicTradesConf coll conf name in PublicCollsConfAccessors service
551df03
ezewer
ezewer approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 2880f5a into bitfinexcom:staging Aug 8, 2024
This was referenced Aug 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZIMkaRU @ezewer