Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PART-6] Add transaction tax report #385

Merged

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Jun 24, 2024

This PR adds ability to interrupt the trx tax report after sign-out and interruption ability in case Rate Limit


Due to long public trade data collecting needs to add trx tax report generation interruption after sign-out. And as well, add a separate endpoint for interruption for better UX
When getting Rate Limit or cool down due to Rate Limit for 1min occurs, it needs to provide a feature to interrupt the tax report and sync being processed


It's a 4-part of the feature, the main idea taken from these PRs: #373, #378, #379

  • separates into small parts
  • improves and speeds up the currency conversion approach

Basic changes:

  • Adds ability to interrupt the trx tax report after sign-out
  • Adds interruptOperations endpoint
  • Implement interruption ability in BfxApiRouter service

  • interruptOperations request example
{
  "auth": {
    "token": "user_token"
  },
  "method": "interruptOperations",
  "params": {
    "names": ["TRX_TAX_REPORT_INTERRUPTER"]
  }
}
  • interruptOperations response example
{
  "jsonrpc": "2.0",
  "result": true,
  "id": null
}

Depends on these PRs:

Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants