Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PART-4] Add transaction tax report #383

Merged

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented May 30, 2024

This PR adds core function and main flow for lookup transactions with required start - end timeframe for Transaction Tax Report


It's a 4-part of the feature, the main idea taken from these PRs: #373, #378, #379

  • separates into small parts
  • improves and speeds up the currency conversion approach

Basic changes:

  • Speeds up back iteration, to not return a new object of iterator result
  • Adds utility to push large array into array
  • Adds a core function for lookup transactions with realized or unrealized profit
  • Implements main flow for lookup transactions with required start - end timeframe

Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants