-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to define what kind of keys are stored prod/staging #347
Merged
ezewer
merged 17 commits into
bitfinexcom:staging
from
ZIMkaRU:feature/add-ability-to-define-type-of-credentials-stored
Jan 3, 2024
Merged
Add ability to define what kind of keys are stored prod/staging #347
ezewer
merged 17 commits into
bitfinexcom:staging
from
ZIMkaRU:feature/add-ability-to-define-type-of-credentials-stored
Jan 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release version 4.13.0
ezewer
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
This was referenced Jan 11, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to define what kind of keys are stored
prod
/staging
:prod
/staging
is detected by existing thestaging
string in therestUrl
config option:https://api-pub.bitfinex.com
/https://api.staging.bitfinex.com
isStagingBfxApi
flag is set or updated on signUp/signIn to theuser
tablegetUsers
endpoint will return theisStagingBfxApi
flag to be shown in the UI for each user on the login stageBasic changes:
isStagingBfxApi
endpointisStagingBfxApi
flag forsignIn
endpointisStagingBfxApi
flag forgetUsers
endpointisStagingBfxApi
flag onsign-up
/sign-in
v39
DB migrationisStagingBfxApi
isStagingBfxApi
request example:isStagingBfxApi
response example:signIn
request example:signIn
response example:getUsers
request example:getUsers
response example: