Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bfx auth token refreshing #336

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Fix bfx auth token refreshing #336

merged 1 commit into from
Nov 24, 2023

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Nov 23, 2023

This PR fixes BFX auth token refreshing. The issue is the following:

  • UI has to make several sign-in requests, for HTTP and WS
  • when making second signIn request, reference to the previous setInterval for token invalidation is lost
  • when signOut and signIn into another account, the previous setInterval continued to work, which caused errors in some cases

ezewer
ezewer approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit 4825ea7 into bitfinexcom:staging Nov 24, 2023
This was referenced Nov 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZIMkaRU @ezewer