Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix candles sync for currency converter #329

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Oct 24, 2023

This PR fixes the candles sync for the currency converter


To convert the first ledgers to USD it needs to provide some overlap of candles:

  • the first entries in the ledgers with their timestamps may not have corresponding entries in the candles
  • in rare cases, this may result in missing several entries when converting to USD
  • the idea is to provide a 5 day overlap of candles in relation to the first entries in the ledgers
  • the ability to convert balances into USD is also added for already synchronized but not converted records (for ordinary users and sub-accounts)

Screenshot from 2023-10-23 14-09-11

Screenshot from 2023-10-23 14-10-07

Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants