Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide currency lists for platform consistency #310

Merged
merged 19 commits into from
Aug 10, 2023
Merged

Provide currency lists for platform consistency #310

merged 19 commits into from
Aug 10, 2023

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Aug 9, 2023

This PR provides currency lists for platform consistency

Basic changes:

  • Adds new symbol list marginCurrencyList -> pub:list:currency:margin to the sync mode
  • Adds new symbol list marginCurrencyList taken from DB to getSymbols endpoint
  • Adds new fields to currencies list of getSymbols endpoint response according to following:
    • active -> true/false if its included in the inactiveCurrencies
    • isInPair -> true/false if its included in the pairs
    • isFunding -> true/false if its included in the marginCurrencyList
  • Adds v37 DB migration
  • Adds corresponding test coverages

Depends on this PR:

prdn and others added 19 commits August 9, 2023 09:04
@prdn
Merge pull request bitfinexcom#309 from bitfinexcom/beta
90618b5 
Release version to master
@ZIMkaRU
Add sync api methods for currency lists
c3a99fd
@ZIMkaRU
Add table names for currency lists
5c9f29b
@ZIMkaRU
Add allowed sync coll names for currency lists
fc7dad1
@ZIMkaRU
Add lableCurrencyMap table model
30d832f
@ZIMkaRU
Add futureCurrencyList table model
f33279c
@ZIMkaRU
Add securityCurrencyList table model
a6deb35
@ZIMkaRU
Add marginCurrencyList table model
a129e1d
@ZIMkaRU
Add lableCurrencyMap sync schema
18dc328
@ZIMkaRU
Add futureCurrencyList sync schema
46c1e91
@ZIMkaRU
Add securityCurrencyList sync schema
4b962a0
@ZIMkaRU
Add marginCurrencyList sync schema
fdedc86
@ZIMkaRU
Add helper to convert array-map to object-map
8aeaf17
@ZIMkaRU
Add api middleware handler for labelCurrencyMap
610879c
@ZIMkaRU
Provide consistent symbols taken from db to getSymbols endpoint
2353290
@ZIMkaRU
Improve test case for getSymbols endpoint
4d99a09
@ZIMkaRU
Remove redundant currency lists from sync mode
744a069
@ZIMkaRU
Bump supported db version up to 37
e339db9
@ZIMkaRU
Add v37 db migration
e62e751
@alexstotsky alexstotsky mentioned this pull request Aug 10, 2023
Merged
2 tasks
ezewer
ezewer approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit 92e0725 into bitfinexcom:beta Aug 10, 2023
This was referenced Aug 23, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZIMkaRU @ezewer @prdn