-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to auto start sync after auto-update of electron app #261
Merged
prdn
merged 22 commits into
bitfinexcom:beta
from
ZIMkaRU:feature/add-ability-to-auto-start-sync-after-auto-update-of-electron-app
Mar 22, 2023
Merged
Add ability to auto start sync after auto-update of electron app #261
prdn
merged 22 commits into
bitfinexcom:beta
from
ZIMkaRU:feature/add-ability-to-auto-start-sync-after-auto-update-of-electron-app
Mar 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2023
Add ability to auto start sync after auto-update of electron app
bitfinexcom/bfx-report-electron#190
Merged
ezewer
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
This was referenced Mar 29, 2023
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to auto-start sync after the auto-update of the electron app. The idea is to have a configurable option (by default turned on) to force sync after the auto-update or DB migration due to changes in the DB schema, the aim is to bring data consistency after significant updates. But the user can turn the option off via the settings menu.
The flow:
shouldNotSyncOnStartupAfterUpdate
flag used to turn on/off the optionisSyncOnStartupRequired
flag used to request syncisSyncOnStartupRequired=true
will be setisSyncOnStartupRequired=flase
will be resetBasic changes:
singIn
request:signIn
response:updateUser
request:updateUser
response: