-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance fees report #234
Merged
Merged
Enhance fees report #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezewer
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the fees report. Basic changes:
getFeesReport
andgetFeesReportCsv
are marked asdeprecated
and after UI implementation and sending to production would be removed in the next PRgetTotalFeesReport
andgetTotalFeesReportCsv
symbol
params should be a string coin (like in ledgers) instead of a pair, eg:"symbol": ["UST", "USD", "BTC"]
isTradingFees: true, isFundingFees: true
params are required, if no one is passed throws an errorisTradingFees
param covers:trading fee
- category 201isFundingFees
param covers:position funding cost or interest charged
- category 27,used margin funding charge
- category 226,unused margin funding fee
- category 228,derivatives funding event
- category 29. Check https://docs.bitfinex.com/reference/rest-auth-ledgers and workers/loc.api/sync/data.inserter/api.middleware/helpers/get-category-from-description.jscumulative
result to a response and to CSV export228
category formargin funding fee
Request example:
Response example:
Depends on this PR: