Fix pushing large array into array for trx tax report

bitfinexcom · May 6, 2024 · 43e2756 · 43e2756
1 parent 579707b
commit 43e2756
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 7 deletions.
diff --git a/workers/loc.api/helpers/index.js b/workers/loc.api/helpers/index.js
@@ -11,7 +11,8 @@ const {
   pickLowerObjectsNumbers,
   sumAllObjectsNumbers,
   pickAllLowerObjectsNumbers,
-  sumArrayVolumes
+  sumArrayVolumes,
+  pushLargeArr
 } = require('./utils')
 const {
   isSubAccountApiKeys,
@@ -33,5 +34,6 @@ module.exports = {
   pickLowerObjectsNumbers,
   sumAllObjectsNumbers,
   pickAllLowerObjectsNumbers,
-  sumArrayVolumes
+  sumArrayVolumes,
+  pushLargeArr
 }
diff --git a/workers/loc.api/helpers/utils.js b/workers/loc.api/helpers/utils.js
@@ -266,6 +266,12 @@ const sumArrayVolumes = (propName, objects = []) => {
   }, [])
 }
 
+const pushLargeArr = (dest, src) => {
+  for (const item of src) {
+    dest.push(item)
+  }
+}
+
 module.exports = {
   checkParamsAuth,
   tryParseJSON,
@@ -276,5 +282,6 @@ module.exports = {
   pickLowerObjectsNumbers,
   sumAllObjectsNumbers,
   pickAllLowerObjectsNumbers,
-  sumArrayVolumes
+  sumArrayVolumes,
+  pushLargeArr
 }
diff --git a/workers/loc.api/sync/transaction.tax.report/index.js b/workers/loc.api/sync/transaction.tax.report/index.js
@@ -1,5 +1,7 @@
 'use strict'
 
+const { pushLargeArr } = require('../../helpers/utils')
+
 const {
   lookUpTrades,
   getTrxMapByCcy,
@@ -120,9 +122,12 @@ class TransactionTaxReport {
       }
     )
 
-    trxsForCurrPeriod.push(...buyTradesWithUnrealizedProfit)
-    trxsForConvToUsd.push(...buyTradesWithUnrealizedProfit
-      .filter((trx) => trx?.isMovements || trx?.lastSymb !== 'USD'))
+    pushLargeArr(trxsForCurrPeriod, buyTradesWithUnrealizedProfit)
+    pushLargeArr(
+      trxsForConvToUsd,
+      buyTradesWithUnrealizedProfit
+        .filter((trx) => trx?.isMovements || trx?.lastSymb !== 'USD')
+    )
     await this.#convertCurrencies(trxsForConvToUsd)
 
     const { saleTradesWithRealizedProfit } = await lookUpTrades(
@@ -207,7 +212,7 @@ class TransactionTaxReport {
           (...args) => this.#getPublicTrades(...args)
         )
 
-        pubTrades.push(...chunk)
+        pushLargeArr(pubTrades, chunk)
       }
 
       convertCurrencyBySymbol(trxData, pubTrades)