Add weighted averages #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release version to master
ezewer
reviewed
Jul 4, 2023
| @@ -50,6 +63,69 @@ class WeightedAveragesReport { | |||
| } | |||
| } | |||
|
|
|||
| async _getWeightedAveragesReportFromApi (args) { | |||
| const limit = 100_000 | |||
There was a problem hiding this comment.
JS shipped a new feature called numeric separator to improve readability on numbers. The underscore _ was introduced in ES2021 as a separator in numbers and we can use it for decimal, binary, hexadecimal, and BigInt numbers
1 task
This was referenced Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to fetch weighted averages data from the BFX API using
v2/auth/r/trades/calcendpointBasic changes:
symbolparam required for weighted averagessymbolwith params schemaWeightedAveragesReportservice to be able to work with api dataNotes:
nextPage === trueit means that data is not consistent and need to change timeframe. That is, when requesting, we set a limit of 100k and in the api response it returns the number of trade records participating in the calculation, if their number has reached the requested limit, this means that the user may not see the data for the desired period of time and it needs to be reduced. This message should be displayed to the userDepends on these PRs: