Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix symbol pair splitting #260

Merged
merged 6 commits into from
Apr 28, 2022
Merged

Fix symbol pair splitting #260

merged 6 commits into from
Apr 28, 2022

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Apr 27, 2022

This PR fixes symbol pair splitting. Basic changes:

  • handles pairs with long characters like tMATICM:USD, MATICMF0 etc
  • adds corresponding test coverage

@ZIMkaRU ZIMkaRU mentioned this pull request Apr 27, 2022
Merged
ezewer
ezewer approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit 21dfc87 into bitfinexcom:beta Apr 28, 2022
This was referenced Apr 28, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZIMkaRU @ezewer @prdn