-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(improvements) Tax report: improve UX during initial sync #888
Open
alexstotsky
wants to merge
12
commits into
bitfinexcom:staging
Choose a base branch
from
alexstotsky:improve-ux-tax-report
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
(improvements) Tax report: improve UX during initial sync #888
alexstotsky
wants to merge
12
commits into
bitfinexcom:staging
from
alexstotsky:improve-ux-tax-report
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release version to master
alexstotsky
changed the title
Improve ux tax report
(improvements) Tax report: improve UX during initial sync
Dec 5, 2024
JasonMHasperhoven
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👍
ezewer
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
elvis-poggi
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks:
https://app.asana.com/0/1163495710802945/1208891975570895/f
https://app.asana.com/0/1163495710802945/1208892028698356/f
Description:
Filter
button toGenerate
and also disables it during the initial synchronization to preventTax Report
generation errorsstaging
with the latestmaster
Preview:
tax-init-sync-flow.mov