Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Assets section for the web summary page #880

Merged
merged 22 commits into from
Oct 24, 2024
Merged

(feature) Assets section for the web summary page #880

merged 22 commits into from
Oct 24, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Oct 18, 2024 •
edited
Loading

Tasks:
https://app.asana.com/0/1163495710802945/1208435230668684/f
https://app.asana.com/0/1163495710802945/1208565976124783/f

Description:

  • Implements Your Assets section for the web Account Summary page
  • Improves sections titles styling
Web summary by asset is implemented in the following way:
- We use getWallets endpoint to receive all wallet balances
- And then summarize it for each available currency

Preview:

your-assets-web-flow.mov

prdn and others added 22 commits October 15, 2024 11:48
@alexstotsky alexstotsky changed the title [WIP] (feature) Assets section for the web summary page (feature) Assets section for the web summary page Oct 18, 2024
@alexstotsky alexstotsky marked this pull request as ready for review October 18, 2024 11:05
ezewer
ezewer approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 0bd2515 into bitfinexcom:staging Oct 24, 2024
@alexstotsky alexstotsky deleted the web-summary-asset branch October 24, 2024 10:24
This was referenced Nov 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn