Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) App summary: active positions section #873

Merged
merged 40 commits into from
Oct 8, 2024
Merged

(feature) App summary: active positions section #873

merged 40 commits into from
Oct 8, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Oct 4, 2024 •
edited
Loading

Tasks:
https://app.asana.com/0/1163495710802945/1208435230668679/f
https://app.asana.com/0/1163495710802945/1208444395422078/f

Description:

  • Implements Active Positions section on the app Summary page

Preview:

summary-active-pos-prev  
summary-active-pos-flow.mov

Depends on:

@alexstotsky
Add active position res mock
8633142
@alexstotsky
Add active positions keys/descriptions
4875cdf
@alexstotsky
Adjust mocked res pos data
ff597a1
@alexstotsky
Update summary mapped methods
4095fbb
@alexstotsky
Implement positions refetch on summary refresh
09d9a84
@alexstotsky
[wip] Summary positions section
c280407
@alexstotsky
Add active positions to the app summary
fd3fcfa
@alexstotsky
Actualize query constants
73417ec
@alexstotsky
Update summary active positions type
511350d
@alexstotsky
[wip] Active position cols config getters
835f776
@alexstotsky
Implement active positions entraies handling flow
d92ab95
@alexstotsky
Fix column getters param providing
67d14ea
@alexstotsky
Add summary positions table styling
c70b91c
@alexstotsky
Fix summary pos refreshing flow
0e3ec9d
@alexstotsky
Actualize classnames
e0f33aa
@alexstotsky
Unused keys cleanup
992ffe4
@alexstotsky
Improve pos loading/no data states handling
9f6e282
@alexstotsky
Enable active pos cols resizing for the framework mode
6b0ea33
@alexstotsky
Adjust cells values types
ebda93c
@alexstotsky
Actualize amount column content
9610b67
@alexstotsky
Merged pl/plPerc cells values representation
93450c9
@alexstotsky
Implement isDerivativePair checker
8a8c967
@alexstotsky
Implement pair cols config, cleanup
9894aa3
@alexstotsky
Update secondary cell vals styling
a4e870a
@alexstotsky
Improve secondary vals for collapsed tables
c0724fb
@alexstotsky
Update positions keys/descriptions
f6ef5e9
@alexstotsky
Improve pairs labels handling
66b4176
@alexstotsky
Actualize collateral value representation
8086924
@alexstotsky
Adjust liq price representation
970ad28
@alexstotsky
Implement formatSecondaryPercentValue helper
e4438b6
@alexstotsky alexstotsky marked this pull request as ready for review October 4, 2024 11:53
@alexstotsky alexstotsky mentioned this pull request Oct 7, 2024
Merged
1 task
ezewer
ezewer approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 58cbea5 into bitfinexcom:staging Oct 8, 2024
@alexstotsky alexstotsky deleted the summary-active-positions branch October 8, 2024 09:29
This was referenced Oct 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @elvis-poggi