Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(improvements) Logins and change logs #840

Merged

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Aug 1, 2024

Task: https://app.asana.com/0/1163495710802945/1207919792578522/f

Description:

  • Enhances and unifies Logins and Change Logs reports column configuration getters according to the recent improvement proposals and reduces redundant code
  • Syncs staging with the latest master

@alexstotsky alexstotsky changed the base branch from master to staging August 1, 2024 09:48
@alexstotsky alexstotsky marked this pull request as ready for review August 1, 2024 11:11
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit ad4100d into bitfinexcom:staging Aug 8, 2024
@alexstotsky alexstotsky deleted the improve-logins-chnglogs-cols-configs branch August 8, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants