Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) OTP login request duplication possibility #838

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Jul 29, 2024

Task: https://app.asana.com/0/1163495710802945/1207921781725071/f

Description:

  • Fixes disabling the Authenticate button during the 2FA login flow to prevent the possibility of requests with the same token duplication and related errors

Before:

otp-duplication-reqs-before.mov

After:

otp-duplication-reqs-after.mov

@alexstotsky alexstotsky marked this pull request as ready for review July 29, 2024 13:17
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 3dabc23 into bitfinexcom:staging Jul 30, 2024
@alexstotsky alexstotsky deleted the fix-otp-req-duplication branch July 31, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants