Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Tax report source column #836

Merged
merged 6 commits into from
Jul 24, 2024
Merged

(feature) Tax report source column #836

merged 6 commits into from
Jul 24, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Jul 24, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1207814579692866/f

Description:

  • Implements Source column representation for the new Tax Report according to the latest requirements
Introduce a new column next to the currency called `Source` with values in the list,
but formatted like `Airdrop on wallet`

Preview:

tax_report_source_col_prev

Depends on:

@alexstotsky alexstotsky changed the title [WIP] (feature) Tax report source column (feature) Tax report source column Jul 24, 2024
@alexstotsky alexstotsky marked this pull request as ready for review July 24, 2024 09:43
ezewer
ezewer approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 7c25c6b into bitfinexcom:staging Jul 24, 2024
@alexstotsky alexstotsky deleted the tax-report-source-col branch July 25, 2024 12:05
This was referenced Jul 31, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @elvis-poggi