Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvements) Invoices configuration getters #827

Merged
merged 28 commits into from
Jun 28, 2024
Merged

(improvements) Invoices configuration getters #827

merged 28 commits into from
Jun 28, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Jun 20, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1207599240564865/f

Description:

  • Reworks and optimizes Invoices report columns configuration getters according to the recent improvement proposals
  • Implements unified getLinkCell and getJsonFormattedCell utilities for better reusability

Depends on:

alexstotsky added 28 commits June 13, 2024 12:26
@alexstotsky
Improve pub trades states handling
02acd3f
@alexstotsky
Implement unified type formatter util
669cb18
@alexstotsky
Optimize type foramtting in pub trades
6223ae8
@alexstotsky
Cleanup
12b2c88
@alexstotsky
Rework and optimize public trades cols configs
db6f9f8
@alexstotsky
Cleanup
aba2ea9
@alexstotsky
Optimize cols getters
01a1fdc
@alexstotsky
Actualize getter import
4f39ea4
@alexstotsky
Lint fix
65061bf
@alexstotsky
Improve pub funding states handling
308e1b6
@alexstotsky
Rework and optimize cell generation flow
63df8ab
@alexstotsky
Improve getCols helper structure and cleanup
3a15846
@alexstotsky
Actualize import
e7257cf
@alexstotsky
Enhance derivative cols states handling
b3ece6e
@alexstotsky
Rework and optimize derivatives cols configs
e82e89c
@alexstotsky
Cleanup
af757a9
@alexstotsky
Improve invoices cell states handling
5b8ed09
@alexstotsky
Rework and enhance invoices regular cells rendering
d6b2197
@alexstotsky
Cleanup
33103ed
@alexstotsky
Improve json formatter styling
9fbd1f7
@alexstotsky
Lint fix
860e6fc
@alexstotsky
Adjust popup sizing
055c75d
@alexstotsky
Implement unified getJsonFormattedCell getter
29c7dc1
@alexstotsky
Rework and optimize json formatted cell configs
618112b
@alexstotsky
Lint fix
f9e5ef6
@alexstotsky
Implement unified getLinkCell getter
debcb0a
@alexstotsky
Rework and optimize linked cell configs
6863f1e
@alexstotsky
Cleanup
7274a6f
@alexstotsky alexstotsky changed the title [WIP] (improvements) Invoices configuration getters (improvements) Invoices configuration getters Jun 20, 2024
@alexstotsky alexstotsky marked this pull request as ready for review June 20, 2024 11:52
ezewer
ezewer approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 6feeb7f into bitfinexcom:staging Jun 28, 2024
@alexstotsky alexstotsky deleted the refactor-invoices-cols-configs branch July 5, 2024 11:09
This was referenced Jul 31, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @elvis-poggi