Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvements) Default column widths #810

Merged
merged 26 commits into from
May 8, 2024
Merged

(improvements) Default column widths #810

merged 26 commits into from
May 8, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Apr 26, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1207110202740010/f

Description:

  • Enhances default column widths calculation flow according to the latest improvements proposals using dynamic calculated average and widths multipliers based on the column types

Preview:

improved_width_default_calcs_prev.mov

Depends on:

prdn and others added 26 commits April 17, 2024 12:38
@prdn
Merge pull request bitfinexcom#807 from bitfinexcom/staging
49972f8 
Release version to master
@alexstotsky
Implement columnHeaderCellRenderer
eb4aa14
@alexstotsky
Fix columns header naming providing
7b14b9f
@alexstotsky
Fix table menu representation
2560abd
@alexstotsky
Extract columnWidthReset handler for better reusability
6c43d8c
@alexstotsky
Optimize columnWidthReset handler
300b990
@alexstotsky
Improve header cell name providing
ddcb0c6
@alexstotsky
Adjust menu availability only for resizable tables
c324afb
@alexstotsky
Minor fix
5b40051
@alexstotsky
Fix headers names alignment
5845207
@alexstotsky
Lint fix
568c731
@alexstotsky
Implement getColumnsMinWidths helper
037e80b
@alexstotsky
Fix columns util export
39bcf48
@alexstotsky
Update first cols defult calculations
d8df559
@alexstotsky
Implement getIsDefaultsWiderThanContainer checker utility
0f5bd28
@alexstotsky
Cleanup
2e7b6ee
@alexstotsky
Implement wide/small columns checking flow
babacc1
@alexstotsky
Update average width calc flow
7fee017
@alexstotsky
Add small/wide cols precalculation flow
a5d81d9
@alexstotsky
Implement columns widths adjustments flow
cab700e
@alexstotsky
Adjust small multiplier
44faf57
@alexstotsky
Enhance average width calcs flow
24fc562
@alexstotsky
Cleanup
0002980
@alexstotsky
Optimize avg width calculation flow
bb47b52
@alexstotsky
Adjust defaults
efb18bc
@alexstotsky
Minor tweak
4046d15
@alexstotsky alexstotsky changed the title [WIP] (improvements) Default column widths (improvements) Default column widths Apr 26, 2024
@alexstotsky alexstotsky marked this pull request as ready for review April 26, 2024 10:32
ezewer
ezewer approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 2ffde90 into bitfinexcom:staging May 8, 2024
@alexstotsky alexstotsky deleted the improve-cols-width-calcs branch May 8, 2024 09:13
This was referenced May 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn