Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(improvements) Navigation menu #804

Merged
merged 13 commits into from
Apr 15, 2024
Merged

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Apr 10, 2024

Task: https://app.asana.com/0/1163495710802945/1206521519232850/f

Description:

  • Enhances Reports navigation menu representation according to the following improvement proposals
We want to tighten up the navigation bar:
- The items that are not active should be grey instead of white
- Parents and sub-items both
- The sub-items should have a reduced line height so that more items will fit
- The sub-item that's active should have a background covering the entire width
- The sub-item should be properly aligned with the parent 

Before:

nav-menu-before.mov

After:

nav-menu-after.mov

@alexstotsky alexstotsky marked this pull request as ready for review April 10, 2024 10:33
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants