Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Add support for emitReportFileGenerationFailedToOne event #787

Merged
merged 38 commits into from
Mar 19, 2024
Merged

(feature) Add support for emitReportFileGenerationFailedToOne event #787

merged 38 commits into from
Mar 19, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Mar 13, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1206792153366826/f

Description:

  • Implements support for emitReportFileGenerationFailedToOne ws events and informs users about report generation failing in these cases

Preview:

export-fail-notify

Depends on:

prdn and others added 30 commits March 6, 2024 08:14
@prdn
Merge pull request bitfinexcom#783 from bitfinexcom/staging
3bad348 
Release version to master
@alexstotsky
Actualize main method naming
c1c9b2f
@alexstotsky
Update deprecated export methods
bc3c2ad
@alexstotsky
Cleanup
7596ab7
@alexstotsky
Actualize localReportFolderPath and remoteReportUrn handling
8a9538e
@alexstotsky
Actualize query constants
5db2cc5
@alexstotsky
Unify export report saga naming
7c650f9
@alexstotsky
Update reducers handling cases and initial entries
8ed6d1d
@alexstotsky
Actualize export selectors
7b7091e
@alexstotsky
Update export dialog mapped props
d74f595
@alexstotsky
Actualize export method and prop-types
f694600
@alexstotsky
Actualize reports exporting actions
030c0c9
@alexstotsky
Update mapped method
daee86b
@alexstotsky
Actualize is exporting constant naming
3bd3c03
@alexstotsky
Update set is exportting action
23712c0
@alexstotsky
Actualize ws constants
c43a75b
@alexstotsky
Update export report saga flow
61dbc3b
@alexstotsky
Actualize ws report generation sagas
e52f8bc
@alexstotsky
Actualize ws constants
9d842a9
@alexstotsky
[wip]Export fail dialog
89ff14e
@alexstotsky
Add fail dialog handling ui constant
0c9591f
@alexstotsky
Implement toggleExportFailDialog action
f14b1c5
@alexstotsky
Update ui reducers cases and init state entries
ea7ef88
@alexstotsky
Add getIsExportFailDialogOpen selector
83697a7
@alexstotsky
Update styles imports
de6bca2
@alexstotsky
Actualize fail dialog icon
9681de8
@alexstotsky
Add export fail dialog to the main
4e7c370
@alexstotsky
Add export failing related keys and descriptions
f7b956b
@alexstotsky
Actualize export fail dialog title and message
af400ee
@alexstotsky
Update dialog classes and cleanup
3d6ea74
@alexstotsky alexstotsky changed the title [WIP] (feature) Add support for emitReportFileGenerationFailedToOne event (feature) Add support for emitReportFileGenerationFailedToOne event Mar 13, 2024
@alexstotsky alexstotsky marked this pull request as ready for review March 13, 2024 11:20
ezewer
ezewer approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit a35a538 into bitfinexcom:staging Mar 19, 2024
@ZIMkaRU ZIMkaRU mentioned this pull request Mar 20, 2024
Merged
@alexstotsky alexstotsky deleted the inform-report-gen-fail branch March 20, 2024 09:43
@ZIMkaRU ZIMkaRU mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn