Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvements) Tables states representation #779

Merged
merged 109 commits into from
Mar 5, 2024
Merged

(improvements) Tables states representation #779

merged 109 commits into from
Mar 5, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Mar 1, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1206056743460087/f

Description:

  • Enhances loading and no data states representation for reports with tables according to the latest design updates

Preview:

ledgers-loading-after.mov

 
ledgers-no-data-after
 

loading+no-data-flow.mov

alexstotsky added 30 commits March 1, 2024 09:19
@alexstotsky
Adjust placeholder default size
923c7eb
@alexstotsky
Implement unified getCellLoader helper
e51d2fe
@alexstotsky
Add cols no result key/description
3109f8d
@alexstotsky
Extend cell statates getter for no data cases
5324224
@alexstotsky
Update ledgers columns configuration
38a5f87
@alexstotsky
Implement getRowsNumber helper utility
6ab30d5
@alexstotsky
[wip]Ledgers preloading representation
1917583
@alexstotsky
Actualize no-data cells styling
c08fb74
@alexstotsky
Fix parent cell related warnings, cleanup
acedfbf
@alexstotsky
Rework ledgers no data handling cases
4f02990
@alexstotsky
Fix pagination flickering and cleanup
461293b
@alexstotsky
Provide first visible cols handling for ledgers no data case
07e9906
@alexstotsky
Implement custom content support for getCellNoData helper
e667d50
@alexstotsky
Implement cell description setting for the first visible columns
ced6666
@alexstotsky
Enhance data table no data state checkig
5699f91
@alexstotsky
Actualize ledgers data table config
b108414
@alexstotsky
Actualize first column description for no data case
f519c56
@alexstotsky
Cleanup and lint fixes
d8a8071
@alexstotsky
Lint fix
7bfbd05
@alexstotsky
Unified getCellLoader utility for better reusability
8d68e46
@alexstotsky
Actualize trades cols configuration
258da52
@alexstotsky
Enhance trades no-data/loading states handling
af36388
@alexstotsky
Extend orders columns getter config
21bf045
@alexstotsky
Fix ledgers rows rendering
dd9a50d
@alexstotsky
Enhance orders loading/no-data states handling
95dc51c
@alexstotsky
Actualize trades data table config
017e042
@alexstotsky
Improve positions cols getters configs
97b114c
@alexstotsky
Enhance positions states handling
3416631
@alexstotsky
Improve active pos tables representation
02b76bd
@alexstotsky
Rework positions audit states handling
394f81c
alexstotsky added 20 commits March 1, 2024 09:20
@alexstotsky
Extend getFrameworkPositionsColumns configuration
6a0c46b
@alexstotsky
Optimize positions cols getter
f327272
@alexstotsky
Enhance position tickers cols configs
54f76db
@alexstotsky
Rework getWalletsTickersColumns states handling
8a68f2b
@alexstotsky
Actualize snapshots configs
8a1462f
@alexstotsky
Rework and optimize tickers snapshot section
f7c598f
@alexstotsky
Rework and improve positions snapshot
063e8d0
@alexstotsky
Enhance ticker snapshot states handling
9909844
@alexstotsky
Cleanup
ddfb8f4
@alexstotsky
Enhance tax report snapshots states handling
eb4eac1
@alexstotsky
Adjust data table num rows handling
c63bc09
@alexstotsky
Implement getRowsConfig utility
b409bf4
@alexstotsky
Rework result movements states handling
d323688
@alexstotsky
Enhace default rows config handling
b744c8c
@alexstotsky
Adjust positions snapshot config
c527e63
@alexstotsky
Actualize rows config
e03023b
@alexstotsky
Update movements cols config
78fc1b9
@alexstotsky
Improve tax balances columns getters
0018cfc
@alexstotsky
Actualize getPositionsSnapshot states handling
8f90fc0
@alexstotsky
Actualize getBalances states ahndling
cf2538d
@alexstotsky alexstotsky marked this pull request as ready for review March 1, 2024 10:12
ezewer
ezewer approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit bb6336b into bitfinexcom:staging Mar 5, 2024
@alexstotsky alexstotsky deleted the improve-tables-loading branch March 5, 2024 10:36
This was referenced Mar 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @elvis-poggi