Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(internal) Migrate from Lodash to the lib-js-util-base  #761

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

alexstotsky
Copy link
Contributor

Task: https://app.asana.com/0/1163495710802945/1205580176871470/f

Description:

  • Replaces Lodash _isObject helper usage with the corresponding one from the internal library for security reasons
  • Updates @bitfinex/lib-js-util-base to the latest version

@alexstotsky alexstotsky marked this pull request as ready for review January 23, 2024 09:29
This was referenced Jan 26, 2024
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ezewer ezewer merged commit 2a8c09a into bitfinexcom:staging Jan 26, 2024
@alexstotsky alexstotsky deleted the replace-is-object branch January 26, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants