Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Summary by asset: configurable balances representation #753

Merged
merged 69 commits into from
Jan 17, 2024
Merged

(feature) Summary by asset: configurable balances representation #753

merged 69 commits into from
Jan 17, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Jan 10, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1206140059050444/f

Description:

  • Implements configurable balances representation Filter for the Summary by Asset section

Preview:

custom_balance_filter_prev.mov

prdn and others added 30 commits January 10, 2024 07:43
@prdn
Merge pull request bitfinexcom#752 from bitfinexcom/staging
471d8d1 
Release version to master
@alexstotsky
Add filter summary icon
b760037
@alexstotsky
Add minimum balance related keys/descriptions
97ef3d7
@alexstotsky
Actualize icons export
1a2f75b
@alexstotsky
Update summary by asset constants
b05b520
@alexstotsky
Add setMinimumBalance action
e240b5d
@alexstotsky
Actualize reducers handling cases, update initial state
f96efe7
@alexstotsky
Implement minimum balance selector
9290f60
@alexstotsky
Enhance input type number appearance
11c8815
@alexstotsky
[wip] Summary by asset filters
96afcf3
@alexstotsky
Add filters to summary by asset section
b33d1c6
@alexstotsky
Update summary filter icon
03ac2fb
@alexstotsky
Fix minimum balance getter
a395993
@alexstotsky
Adjust summary filters positioning
ff3c331
@alexstotsky
Adjust summery filters row
346e194
@alexstotsky
Update summary constants
1266ecc
@alexstotsky
Add min balance usage action
70abf66
@alexstotsky
Update summary by asset reducers
cd88dab
@alexstotsky
Add getUseMinBalance selector
37612ed
@alexstotsky
[wip] Summary filters handlers
eeeeb88
@alexstotsky
Adjust summary filter icon
414bf32
@alexstotsky
Add summery filters btn styling
d0d93a0
@alexstotsky
Add summary filter button
394370f
@alexstotsky
Improve filters icon positioning and styling
1d9c02f
@alexstotsky
Actualize colors and on hover behavior
bbf6515
@alexstotsky
Rework and improve summary by asset titles section
b3a8138
@alexstotsky
Fix summary filters modal positioning
3ba54e7
@alexstotsky
Fix filter flickering on refresh
9f1416c
@alexstotsky
Adjust icon config
fc8b38b
@alexstotsky
Actualize filters active state styling
94cce80
@alexstotsky
Add minimum balance input
a83722c
@alexstotsky
Fix input key values types related warnings
3043bad
@alexstotsky
Allow optional labels for input keys
8e1a8dc
@alexstotsky
Adjust initial minimum balance
cc2883d
@alexstotsky
Implement balance changing flow
de89b9b
@alexstotsky
Add customizable disabled state for input key
836f5c8
@alexstotsky
Claenup
e56d6e3
@alexstotsky
Adjust minimum balance input styling
df9b7de
@alexstotsky
Implement minimum balance disabled state handling and representation
2e1b5c6
@alexstotsky
Add input balance currency icon
1b02cf9
@alexstotsky
Implement currency type styling and positioning
474bc6a
@alexstotsky
Update getMinimumBalance selector
6dddbb2
@alexstotsky
Improve balance value handling
1ecea78
@alexstotsky
Update summary by asset reducers
df84411
@alexstotsky
Update balance target value setting
52a7c60
@alexstotsky
Actualize prepareSummaryByAssetData handler
1697bdd
@alexstotsky
Implement minimum balances handling flow
b58dca1
@alexstotsky
Improve merged entries filtering flow
d7b7a6e
@alexstotsky
Lint fix
4a033be
@alexstotsky
Cleanup
9693da9
@alexstotsky
Update getUseMinBalance selector default
faecf7c
@alexstotsky alexstotsky changed the title [WIP] (feature) Summary by asset: configurable balances representation (feature) Summary by asset: configurable balances representation Jan 11, 2024
@alexstotsky alexstotsky marked this pull request as ready for review January 11, 2024 10:09
ezewer
ezewer approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 3af7acb into bitfinexcom:staging Jan 17, 2024
@alexstotsky alexstotsky deleted the show-minimum-balance branch January 17, 2024 09:44
This was referenced Jan 31, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn