Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvements) Summary by asset: actualize columns #746

Merged
merged 40 commits into from
Dec 13, 2023
Merged

(improvements) Summary by asset: actualize columns #746

merged 40 commits into from
Dec 13, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Dec 12, 2023 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1206140059050433/f

Description:

  • Reworks and actualizes Summary by Asset columns representation according to the latest proposals and backend updates
- Added Trading Fees and Funding Earnings
- Updated Balance, Balance Change, Currency and Volume

Preview:

actualized_summary_by_asset_columns

Depends on:

alexstotsky added 30 commits December 6, 2023 12:12
Actualize summary by asset sagas flow
23c9a2c
Implement sum by asset auto refresh on date range change
6a8e1cb
Actualize summary by asset title
cc63941
Remove outdated key/description
3baf5d0
Adjust spacing
56b5596
Add fee tier keys/descriptions
b1b3b26
Implement getFeeTierVolume helper
85251ee
Provide fee tier vol to app summary fees
f1c80f0
Add fee tier column configuration
c1d45f4
Implement description support in the collapsed tables
ccb6176
Adjust acc fees cols sizing
8f34659
Update cell description styling
f785cbe
Lint fix
48bb722
Add fee tier description
fc67ced
Adjust chart aspect
a3d4073
Remove profits column from the summ by asset cols getter
dca85c6
Adjust columns sizing
0a97315
Update cells styling
b3b5441
Update account fees keys/descriptions
db1a48f
Actualize feeTierVolume cell config
f02f328
Actualize chart aspect
31875f6
Add sum by asset sub-tile key/description
fda2706
Actualized dates formatter
01ac98d
Implement selected date range as sub-title showing in summary by asset
aa839da
Add fees key/description
f30cdec
Actualize balance cols representation
869c6e0
Add fund_earnins key/description
1cb4e53
Improve is total check
d1966c3
Extract isTotal checker fro beter reusability
0569505
Add fees/earnings columns, adjust sizing
e527685
@alexstotsky alexstotsky changed the title [WIP] (improvement) Summary by asset: actualize columns (improvement) Summary by asset: actualize columns Dec 12, 2023
@alexstotsky alexstotsky marked this pull request as ready for review December 12, 2023 11:18
@alexstotsky alexstotsky changed the title (improvement) Summary by asset: actualize columns (improvements) Summary by asset: actualize columns Dec 12, 2023
ezewer
ezewer approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit 4b67538 into bitfinexcom:staging Dec 13, 2023
@alexstotsky alexstotsky deleted the summary-by-asset-updates branch December 13, 2023 13:21
This was referenced Dec 13, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

@elvis-poggi elvis-poggi Awaiting requested review from elvis-poggi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @elvis-poggi