Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(improvement) Balance change representation #736

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Nov 27, 2023

Task: https://app.asana.com/0/1163495710802945/1205968599642845/f

Description:

  • Improves Balance Change representation in the Summary by Asset section according to the following proposals:
- Hide 0% on balance change if the balance was previously 0 e.g. 
EUR was 0 and then it was deposited all current amount balance 432 balance change is also 432, 
it is confusing for users to have a percentage balance change 0% simply should be removed 

- If the balance change is 0$, then 0% should stay

Before:

balance-change-before

After:

balance-change-after

@alexstotsky alexstotsky changed the title [WIP] (improvement) Balance change representation (improvement) Balance change representation Nov 27, 2023
@alexstotsky alexstotsky marked this pull request as ready for review November 27, 2023 11:47
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit 3165546 into bitfinexcom:staging Nov 28, 2023
@alexstotsky alexstotsky deleted the hide-0-perc-balance-change branch November 28, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants