Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) New Summary: account fees and Leo level #709

Merged
merged 61 commits into from
Sep 29, 2023
Merged

(feature) New Summary: account fees and Leo level #709

merged 61 commits into from
Sep 29, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Sep 25, 2023 •
edited
Loading

Tasks:
https://app.asana.com/0/1163495710802945/1204776097979485/f
https://app.asana.com/0/1163495710802945/1205133325932381
https://app.asana.com/0/1163495710802945/1205133325932385

Description:

  • Implements Account Fees and LEO level sections on the new Summary for the Reports app
  • Syncs staging with the latest master

Preview:

summary_fees_leo_prev

prdn and others added 30 commits September 21, 2023 12:53
@prdn
Merge pull request bitfinexcom#708 from bitfinexcom/staging
95af03e 
Small patch to production
Add summary section keys/descriptions
a8e1f44
[wip]New app summary
ecb4cd3
Add app summary styling, update export
538b832
Update main routing to show app summary for the framework mode
1faa824
Actualize section title
ffa1b3e
Adjust sections headers titles
448f50e
Add leo level icon
992aaf7
Update icons export
f89c1cf
Improve leo icon styling
f313d41
Adjust affiliates link icon
0efe876
Improve section header popover positioning
2c2086c
Rework summary header title
46f9bac
Add leo level color vars
0cb91a5
Add app summary wrapper
f9cbd28
Add leo, avg amount keys/descriptions
6706d03
[wip] Rework leo section
ed61a2c
Improve summary title row & items positioning
97b54d6
Add leo level section to the summary header
a756b9d
Cleanup
35e2417
Rework t usage via hook, actualize prop-types
e3105cb
Redundant provided params cleanup
8f4d232
Actualize leo level titles styling
d78596d
Rework leo level/avg amount representation
8113fae
Update prop-types
e1bbf6c
Improve sub-items aligning
a004631
Add leo icon to the leo section
0881903
Adjust leo icon and titles styling
7242fff
Adjust app summary card spacing
a1df426
Remove redundant sections from app summary
8becc4b
@alexstotsky alexstotsky changed the title [WIP] (feature) New Summary: account fees and Leo level (feature) New Summary: account fees and Leo level Sep 25, 2023
@alexstotsky alexstotsky marked this pull request as ready for review September 28, 2023 07:27
ezewer
ezewer approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit e1d39b2 into bitfinexcom:staging Sep 29, 2023
alexstotsky pushed a commit to alexstotsky/bfx-report-ui that referenced this pull request Oct 2, 2023
Revert "Merge pull request bitfinexcom#709 from alexstotsky/summary-f…
8b9189c 
…ees-leo"

This reverts commit e1d39b2, reversing
changes made to 0d00bb1.
@alexstotsky alexstotsky mentioned this pull request Oct 2, 2023
Merged
1 task
ezewer added a commit that referenced this pull request Oct 2, 2023
@ezewer
Merge pull request #713 from alexstotsky/revert#709
21ce258 
(internal) Revert "Merge pull request #709 from alexstotsky/summary-fees-leo"
@alexstotsky alexstotsky mentioned this pull request Oct 6, 2023
Merged
3 tasks
@alexstotsky alexstotsky deleted the summary-fees-leo branch October 9, 2023 08:14
alexstotsky pushed a commit to alexstotsky/bfx-report-ui that referenced this pull request Oct 12, 2023
Revert "Merge pull request bitfinexcom#709 from alexstotsky/summary-f…
e80c0b5 
…ees-leo"

This reverts commit e1d39b2, reversing
changes made to 0d00bb1.
alexstotsky pushed a commit to alexstotsky/bfx-report-ui that referenced this pull request Oct 13, 2023
Revert "Merge pull request bitfinexcom#709 from alexstotsky/summary-f…
f3d87d5 
…ees-leo"

This reverts commit e1d39b2, reversing
changes made to 0d00bb1.
alexstotsky pushed a commit to alexstotsky/bfx-report-ui that referenced this pull request Oct 18, 2023
Revert "Merge pull request bitfinexcom#709 from alexstotsky/summary-f…
1b01aab 
…ees-leo"

This reverts commit e1d39b2, reversing
changes made to 0d00bb1.
alexstotsky pushed a commit to alexstotsky/bfx-report-ui that referenced this pull request Oct 20, 2023
Revert "Merge pull request bitfinexcom#709 from alexstotsky/summary-f…
2233350 
…ees-leo"

This reverts commit e1d39b2, reversing
changes made to 0d00bb1.
alexstotsky pushed a commit to alexstotsky/bfx-report-ui that referenced this pull request Oct 24, 2023
Revert "Merge pull request bitfinexcom#709 from alexstotsky/summary-f…
d3b7941 
…ees-leo"

This reverts commit e1d39b2, reversing
changes made to 0d00bb1.
alexstotsky pushed a commit to alexstotsky/bfx-report-ui that referenced this pull request Oct 26, 2023
Revert "Merge pull request bitfinexcom#709 from alexstotsky/summary-f…
803cc3b 
…ees-leo"

This reverts commit e1d39b2, reversing
changes made to 0d00bb1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn