Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Movements extra info #702

Merged
merged 68 commits into from
Sep 19, 2023
Merged

(feature) Movements extra info #702

merged 68 commits into from
Sep 19, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Sep 14, 2023 •
edited
Loading

Tasks:
https://app.asana.com/0/1163495710802945/1204831118966154/f
https://app.asana.com/0/1163495710802945/1204407756387769/f

Description:

Preview:

extra_info_representation_prev

extra_info_representation_flow.mov

Depends on:

alexstotsky added 30 commits September 11, 2023 13:57
Fix openssl-provider compatibility issue for node 18.x
0aeaf9e
Actualize engines versions
faf4146
Actualize lockfileVersion
293bf3c
Fix package info importing issue
9227f0d
Update react-scripts to 5.0.1
3161832
Fix babel-eslint related issue
8a99e15
Compatibility fixes
1b1eff5
Update columns keys/descriptions
139d3c2
Actualize movements constants
29f61cc
Implement more details column for movements
9d4d25f
Improve extra description tooltip
2e101c8
Actualize cols selector config
df1c6b0
Update columns utils
92f866c
Fix duplicated cols ids warning
dbc7e89
Update movements prop-types
829390b
Fix parent cell related warnings
5b9b404
Add extra movement info action
3ca1765
Update anchor is valid rule for the links
950fe6e
Cleanup
2b47013
Actualize mapped methods
7cf7767
Update movements methods and prop-types
7c44022
[wip]Extra info saga
a0e43e3
Add getExtraInfo errors handling
670f91a
Update movements constants
2283863
Add extra info handling case
bda8679
Update getExtraInfo saga
f08a29a
Add setMovementInfo action
f8ac991
Actualize movements selectors
54e82e9
Update ui constants
17f7290
Add show extra info related action
4eb47fd
@alexstotsky alexstotsky changed the title [WIP] (feature) Movements extra info (feature) Movements extra info Sep 14, 2023
@alexstotsky alexstotsky marked this pull request as ready for review September 14, 2023 13:27
ezewer
ezewer approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit a583a2e into bitfinexcom:staging Sep 19, 2023
@alexstotsky alexstotsky deleted the extra-info-4-movements branch September 19, 2023 07:55
This was referenced Sep 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @elvis-poggi