Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Notifications positioning on scroll #686

Merged
merged 5 commits into from
Aug 14, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Aug 2, 2023

Task: https://app.asana.com/0/1163495710802945/1204977337818189/f

Description:

  • Fixes notifications positioning on page scrolling:
    When setting Table Scroll is turned off, the results of using 'Sum' can appear below or above the part of the table that's currently visible. It would be nice if this could be anchored to a specific part of the currently visible screen rather than a specific point in the table.
  • Syncs beta with the latest master

Before:

sum_toast_before.mov

After:

sum_toast_after.mov

@alexstotsky alexstotsky marked this pull request as ready for review August 2, 2023 12:09
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@prdn prdn merged commit 7de91f6 into bitfinexcom:beta Aug 14, 2023
@alexstotsky alexstotsky deleted the improve-toast-position branch August 15, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants