Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Accounts registration type #670

Merged
merged 1 commit into from
Jun 30, 2023
Merged

(fix) Accounts registration type #670

merged 1 commit into from
Jun 30, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Jun 27, 2023 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1204814230933799/f

Description:

  • Fixes issues with the incorrect accounts registration type detection during the following scenario:
- register a new account via API key/secret
- after the first sign-in ---> logout
- the incorrect type Login instead of API key will be shown once, before the first page refreshing

Before:

registration_type_before_1 registration_type_before_2

After:

registration_type_after.mov

@alexstotsky alexstotsky changed the base branch from master to beta June 27, 2023 07:39
@alexstotsky alexstotsky marked this pull request as ready for review June 27, 2023 10:31
ezewer
ezewer approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@prdn prdn merged commit 0c13696 into bitfinexcom:beta Jun 30, 2023
@alexstotsky alexstotsky deleted the fix-acc-reg-type branch July 3, 2023 08:14
This was referenced Jul 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn