Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Removing accounts from the login modal #662

Merged
merged 30 commits into from
Jun 15, 2023
Merged

(feature) Removing accounts from the login modal #662

merged 30 commits into from
Jun 15, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Jun 12, 2023 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1204257272518551/f

Description:

  • Implements the possibility of removing registered accounts from the main Sign In screen

Preview:

remove_account
rm_protected_acc_flow.mov

alexstotsky added 30 commits June 12, 2023 11:04
Add rm account key/description
535f7f5
Update sign in list methods
a214e20
Add remove account item to users actions popup
dcecd46
[wip] handleDeleteUser method
19afb19
Actualize SignInListItem methods and prop-types
d2da012
Implement optional availability for additional accounts action
f19e7fa
Update user menu rendering conditions
10b25bb
Update auth constants
0af9526
Add delete account action
8a866e9
Update sign in container
9e514ab
Implement handleDeleteUser method, update prop-types
263494d
[wip] Delete account saga
c18f0e3
Add acc removed key/description
095cb1d
[wip] Delete protected account sub-section
a854310
Add account removing success notification
0b21a5f
Implement deleteAccount saga errors handling
d6333f7
Update translations
bcc0120
Improve acc deleting errors cases hadnling
e2d54eb
[wip] Register to delete section
e114e2d
Add delete account setion styles
ca37553
Implement showDeleteAccount render handling
6fd4944
Add selected for removing acc section
2ef9920
Update locales
69d7253
Update handleDeleteUser method
bec717d
Actualize selected user checkers
bacad45
Implement deleteProtectedAccount handler
7cdd778
Provide pwd value to delete account
aea9235
Update prop-types
13c5b97
Add back to main login list after the acc removing, cleanup
68b9521
Lint fix
250f210
@alexstotsky alexstotsky changed the title [WIP] (feature) Removing accounts from the login modal (feature) Removing accounts from the login modal Jun 12, 2023
@alexstotsky alexstotsky marked this pull request as ready for review June 12, 2023 09:27
@alexstotsky alexstotsky changed the base branch from master to beta June 14, 2023 15:05
@alexstotsky alexstotsky mentioned this pull request Jun 15, 2023
Merged
1 task
ezewer
ezewer approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit e843c27 into bitfinexcom:beta Jun 15, 2023
@alexstotsky alexstotsky deleted the rm-accs-from-auth-modal branch June 20, 2023 10:39
This was referenced Jun 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn