Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Ability to name multiple accounts #650

Merged
merged 15 commits into from
May 22, 2023
Merged

(feature) Ability to name multiple accounts #650

merged 15 commits into from
May 22, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented May 15, 2023 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1204388320575679/f

Description:

  • Implements the possibility of optional naming for multiple accounts during creating or updating
  • Implements displaying optional localUsername (if available) instead of the account email

Preview:

multy-accs-group-naming-flow.mov

Depends on:

@alexstotsky alexstotsky changed the title [WIP] (feature) Ability to name multiple accounts (feature) Ability to name multiple accounts May 15, 2023
@alexstotsky alexstotsky marked this pull request as ready for review May 15, 2023 12:00
@alexstotsky alexstotsky mentioned this pull request May 22, 2023
Merged
5 tasks
ezewer
ezewer approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit ef19528 into bitfinexcom:beta May 22, 2023
@alexstotsky alexstotsky deleted the name-multi-accs branch May 22, 2023 12:10
This was referenced May 24, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn