Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvements) Sign In/Add Accounts sections #644

Merged
merged 131 commits into from
May 9, 2023
Merged

(improvements) Sign In/Add Accounts sections #644

merged 131 commits into from
May 9, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented May 9, 2023 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1204362385624827/f

Description:

  • Reworks and improves Sign In and Add Accounts sections according to the latest design updates to enhance users experience
  • Reworks and unifies several related sub-sections for better composition and reusability
  • Implements new flow for adding sub-accounts to the users registered via API keys
  • Actualizes related elements styling and fields descriptions

Preview:

new-sign-in-add-accs-flow.mov

new-sign-in-users-list

new-sign-in-selected-account

alexstotsky added 30 commits May 9, 2023 10:04
Actualize sign in dialog header
daa23bf
Update keys/descriptions
a71b85b
[wip] Sign in users list
adb3472
Update main sign section
44e8d87
Add users list classnames, update auth styles import
4b5ea65
Add user item styling
68120ff
Implement handleUserItemSelect handler
91b254d
Update SignInList methods and prop-types
f121aa6
Improve sign-in dialog spacing
90c782b
Add user item selection handling
7a3be86
Add showUsersList render checker
73b186c
Implement selected user section
4a069db
[wip] Rework sign in flow
1682499
Outdated component cleanup
9fe29ae
Improve user item styling
d7d9e91
Add user list icons
1d796ca
Improve sign in item spacing
68d5140
Add sign-in wrappers, update default state
9861c3e
Update styling
34058f6
Improve user item spacing
1ea617d
Update selected user styling
3a29541
Fix user list keys warning
bcf231d
Add selected user render checker
90d5bbe
Implement auth mode swicthing form the users list, updated prop-types
a7ab82c
Fix login otp btns aligning
d32e8bd
Update login otp classnames
acbce23
Remove unused mode switcher, update provided methods
2acd8c2
Improve selected user showing cases handling
100fd90
Improve sign in footer spacing
0a49693
Add dedicated pwd section render checker
09c2e2a
alexstotsky added 22 commits May 9, 2023 10:05
Improve add accounts link representation
262c1a5
Improve sub-users stuling
c433490
Update add section spacing
3d64f16
Update locales
bfe6313
Improve confirm btn styling
88538ab
Rework and improve sub-accounts actions row
74e9649
Fix spacing
60bec13
Add filterRestrictedUsers utility
a86a29d
Improve sub-accounts allowed users handling
d6c6cfc
Improve styling
7905942
Cleanup
64cd499
Lint fix
33648cb
Code readability improvements
3187cfd
Actualize sign up props and helpers
87a38af
Update auth methods provided to sign up
cca5d05
Remove unused auth type selector
4fe5d83
Actualize auth style imports
182a927
Improve remove sub-accs btn render checker
8c8d7de
Prevent removing sub-accs during syncing
0637bbb
Improve login password render checker
31a10d6
Fix staled pwd on changing selected user
b57ca9a
Improve add sub-accs btn title
c9cf00e
@alexstotsky alexstotsky changed the title [WIP] (improvements) Sign In/Add Accounts sections (improvements) Sign In/Add Accounts sections May 9, 2023
@alexstotsky alexstotsky marked this pull request as ready for review May 9, 2023 09:02
ezewer
ezewer approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit ce811b1 into bitfinexcom:beta May 9, 2023
This was referenced May 10, 2023
Merged
Merged
@alexstotsky alexstotsky deleted the improve-sign-in branch May 10, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn