Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(internal) Actualize node/npm and related fixes #640

Merged
merged 8 commits into from
May 8, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Apr 30, 2023

Task:
https://app.asana.com/0/1163495710802945/1204501873281591/f
https://app.asana.com/0/1163495710802945/1204521029418827/f

Description:

  • Upgrades the used node and npm versions to the following:
Node.js: 16.20.0
npm: 8.19.4

due to the end of the Node.js v14.x branch lifecycle

  • Actualizes eslint and several related packages due to the warnings
  • Fixes forbidden prop-types and other lint fixes
  • Adds .npmrc config to fix these issues

@alexstotsky alexstotsky changed the base branch from master to beta April 30, 2023 09:05
@alexstotsky alexstotsky marked this pull request as ready for review May 2, 2023 11:53
@alexstotsky alexstotsky marked this pull request as draft May 3, 2023 09:19
@alexstotsky alexstotsky changed the title (internal) Actualize node and npm (internal) Actualize node/npm and related fixes May 3, 2023
@alexstotsky alexstotsky marked this pull request as ready for review May 3, 2023 12:32
@alexstotsky alexstotsky marked this pull request as draft May 5, 2023 11:45
@alexstotsky alexstotsky marked this pull request as ready for review May 5, 2023 12:52
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit 874d30f into bitfinexcom:beta May 8, 2023
@alexstotsky alexstotsky deleted the upd-node-npm branch May 9, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants