Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvements) Add account section #635

Merged
merged 71 commits into from
Apr 24, 2023
Merged

(improvements) Add account section #635

merged 71 commits into from
Apr 24, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Apr 18, 2023 •
edited
Loading

Tasks:
https://app.asana.com/0/1163495710802945/1204362385624827/f
https://app.asana.com/0/1163495710802945/1204369924656481/f

Description:

  • Reworks and improves Add Account authorization section according to the latest design updates to enhance users experience
  • Makes Remember Me feature always active and removes unused corresponding checkboxes from all auth sections
  • Reworks and unifies several related sub-sections for better composition and reusability
  • Actualizes elements styling and fields descriptions

Before:

add_account_before

After:

add_account_after

alexstotsky added 30 commits April 18, 2023 11:58
Enable isPersisted by default
a61ec97
Adjust bfx logo size
65e5266
Remove unused checkbox
5e907d0
Actualize add account section header
88e81d7
Improve auth dialog sizing
d0cfbb1
Actualize pwd protection description
8240365
Lint fix
6f92fbd
Improve checkbox styling
11f83c6
Actualize auth dialog spacing
227705c
Update platform logo styling
d4f2561
Adjust input key height
cb3a9ef
Actualize secondary text color
4fbbc85
Improve checkbox labels styling
c7025d6
[wip] LoginApiKey section
5a8d386
Actualize fields and prop-types
b52130a
Rework use api key with unified sub-section
2b08a00
Improve input handler naming
5016e53
Improve key_url handling
c627ae4
Unused component cleanup
4771d77
Improve link splitting
51a54df
Rework api note without callout
11d196e
Improve api key note spacing
908b64f
Update locales
0a56a17
Actualize api key/secret fields labels
32699e8
Add showLoginPassword checker
310affe
[wip] Login password sub-section
db9ff08
Add pwd error labels, actualize prop-types
96e032e
Rework passwords with unified sub-component
fba181d
Lint fix
be77cce
Improve checkboxes aligning
ee95493
@alexstotsky alexstotsky changed the base branch from beta to master April 18, 2023 09:39
@alexstotsky alexstotsky changed the base branch from master to beta April 18, 2023 09:39
@alexstotsky alexstotsky changed the title [WIP] (improvements) Add account section (improvements) Add account section Apr 18, 2023
@alexstotsky alexstotsky marked this pull request as ready for review April 18, 2023 13:49
@alexstotsky alexstotsky mentioned this pull request Apr 22, 2023
Merged
4 tasks
ezewer
ezewer approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit cbdec84 into bitfinexcom:beta Apr 24, 2023
@alexstotsky alexstotsky deleted the improve-add-account branch April 24, 2023 12:40
This was referenced Apr 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn