Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Weighted averages report web version #631

Merged
merged 32 commits into from
Apr 10, 2023
Merged

(feature) Weighted averages report web version #631

merged 32 commits into from
Apr 10, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Apr 9, 2023 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1204293460597897/f

Description:

  • Implements Weighted Averages report representation and corresponding functionalities for the web users
  • Adds 2,000 transactions limit notification when this threshold is reached with a proposal to download our app with extended functionality

Preview:

web_weighted_avgs_with_limit_note

web_weighted_avgs

Depends on:

alexstotsky added 30 commits April 10, 2023 10:34
Move weighted avgs to public targets
c4a5f4e
Improve showFrameworkMode checker usage
f822dca
Actualize base reducers entries configuration
b9bc63b
Update root saga configuration
959c570
Allow weighted avgs section render for non-framework
a2b7440
Implement getSubSectionsTitle helper
1e79dbd
Actualize weighted avgs sections switch redering conditions
81c11f0
Improve weghted avgs data and nexPage value handling
16ecf25
Update main routing, improve framework checks
2e17898
Implement wa next page selector
a9f86fa
Update weighted avgs container
bff70d2
Add secondary text color vars
e59b68d
Update prop-types/defaults
968701c
[wip]Add limit note
ac3a12b
Update mapped props
4538051
Add limit note to weighted averages, upd prop-types
0e7681b
Implement note render check
fecd53b
Update styles imports
324c1d7
Add dedicated classname to the weighted avgs card
8cca41a
Rework limit note header
0f26230
Update locales
5544fe6
Add note title styling
51d01f2
Implement display date section
3926774
Add limit notes keys/descriptions
10c1e2c
Add note text styling
87fabab
Update translations
c6c6168
Improve note spacing
f085ad4
Update colors
69ff347
Implement limit note description
1145131
Improve link spacing
d29c86f
@alexstotsky alexstotsky changed the base branch from master to beta April 10, 2023 07:35
@alexstotsky alexstotsky changed the title [WIP] (feature) Weighted averages report web version (feature) Weighted averages report web version Apr 10, 2023
@alexstotsky alexstotsky marked this pull request as ready for review April 10, 2023 08:19
ezewer
ezewer approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit 358066b into bitfinexcom:beta Apr 10, 2023
@alexstotsky alexstotsky deleted the weighted-avgs-web branch April 11, 2023 07:45
This was referenced Apr 12, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn