(fix) Wrong symbol param for getPublicTrades request #626
Conversation
There was a problem hiding this comment.
The way this was map i dont think its entirely correct.
Not that this PR introduce the errors, but that the errors where displayed by last changes.
Logic should be the following:
1 - From Api we receive pairs, currencies, inactiveSymbols, mapSymbols, inactiveCurrencies
Pairs before being sent to backend should add the t as to get the tranding pair t${pair}
2 - As to display pairs, we should:
a - look if pair has its equivalent in mapSymbols
b - Split the pair into 2 currencies (get each currency from currencies array), this might have ':' as to split or be pair.length === 6 (3 and 3)
3 - Currencies have an ID and a name to display
4 - In movements display all the symbols
5 - For rest, filters the one that dont are in trading pairs.
6 - For the places now added ad f${symbol.id} (only the filtered ones)
| @@ -8,7 +8,7 @@ export * from './mapping' | |||
| // BTCUSD -> tBTCUSD | |||
| // BTCF0:USDF0 -> tBTCF0:USDF0 | |||
| // USD -> fUSD | |||
| const addPrefix = (symbol = '', isFunding = false) => ( | |||
| export const addPrefix = (symbol = '', isFunding = false) => ( | |||
There was a problem hiding this comment.
So i would definitely change this.
What would do is the following:
1 - Add t to each result from pairs, that should be the trading pair.
const tradingPairs = pairs.map(p => `t${p}`)| @@ -61,7 +61,7 @@ export const getSymbolsURL = (symbols) => { | |||
|
|
|||
| // BTC:USD -> BTCUSD | |||
| // BTCF0:USTF0 -> BTCF0:USTF0 | |||
| const deformatPair = pair => ((pair.length === 7) ? pair.replace(':', '') : pair) | |||
| export const deformatPair = pair => ((pair.length === 7) ? pair.replace(':', '') : pair) | |||
There was a problem hiding this comment.
Same that comment below, there should not be a need to replace ':'
There was a problem hiding this comment.
Following our recent deliberations, we have decided to proceed with merging this pull request as an interim patch to address the immediate concern. Meanwhile, we will continue working towards a comprehensive solution that effectively resolves all legacy case scenarios.
Task: https://app.asana.com/0/1163495710802945/1204298582161856/f
Description:
symbolparam for thegetPublicTradesrequest in some casesSymbol Filterwidth to fit better for all available pairsBefore:
After: