Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvement) Sub-accounts creation #578

Merged
merged 4 commits into from
Dec 2, 2022
Merged

(improvement) Sub-accounts creation #578

merged 4 commits into from
Dec 2, 2022

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Dec 1, 2022 •
edited
Loading

Tasks:

Description:

  • Prevents the possibility of Sub Account creation submission if the Master Account hadn't been selected or registered
  • Fixes Sign Up modal overlay styling

Before:

no-master-acc-selected-before.mov

After:

no-master-acc-selected-after.mov

@alexstotsky alexstotsky marked this pull request as ready for review December 1, 2022 12:43
ezewer
ezewer approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit 0d966de into bitfinexcom:beta Dec 2, 2022
@alexstotsky alexstotsky deleted the prevent-sub-acc-req-if-no-master-acc branch December 3, 2022 05:13
This was referenced Dec 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn