Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Win/loss vs balances report % against the previous day #545

Merged
merged 30 commits into from
Sep 19, 2022
Merged

(feature) Win/loss vs balances report % against the previous day #545

merged 30 commits into from
Sep 19, 2022

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Sep 9, 2022 •
edited
Loading

Task: [UI] win/loss vs balances report % against the previous day

Description:

  • Implements Percentage Gains (gains/deposits) and Percentage Gains (gains/balance) reports representation and appropriated logic
  • Fixes issues with selected Unrealized Profits and Report Type params dropping to defaults on Average Win/Loss report refresh
  • Improves props linting and actualizes prop-types and defaults in the several related components

Preview:

win.loss.vs.balances.report.against.the.previous.day.mov

alexstotsky added 30 commits September 9, 2022 11:34
Add gains keys/descriptions
4a6f22c
Improve report type selector styling
b8b458b
Add gains deposits/balance descriptions
2797b55
Fix locales nesting
dab5d19
Update win/loss initial state
36a1127
Actualize getParams selector
cb47bf2
Update report types constants
afb988c
Unify report types titles for better reusability
18be8fd
Implement uinified report type item
4237a90
[wip] Rework report type selector
d87cd6e
Update item prop-types and memoize
962bcf5
Implement getReportTypeParams helper
8fd2db2
Update win/loss constants
c8c00a2
Rework report types change handler
5977400
Update type selector props, unused wrapper cleanup
199ab53
Fix report selector value persisting
a7ed0b3
Add report type handling case to reducers, update initial state
2dc4dff
Update win/loss actions and selectors
6196180
Cleanup
e92103f
Update win/loss conatiner
4010c20
Refactor and memoize report type selector
1549625
Fix fetching params handling
9468a8e
Fix select items related warnings
1731590
Fix items descriptive tooltips flickering
b0129aa
Actualize select types/defaults, improve props linting
6e23014
Implement vsPrevDayBalance handling in saga
42f75c9
Fix selected params persisting on refreshing
91201d4
Improve report types selector styling
508d152
Improve win/loss props validation, update types/defaults
7c7722f
Improve export and cleanup
3738df8
@alexstotsky alexstotsky changed the title [WIP] (feature) Win/loss vs balances report % against the previous day (feature) Win/loss vs balances report % against the previous day Sep 9, 2022
@alexstotsky alexstotsky marked this pull request as ready for review September 9, 2022 13:46
@alexstotsky alexstotsky mentioned this pull request Sep 15, 2022
Merged
2 tasks
ezewer
ezewer approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit 2dd2df8 into bitfinexcom:master Sep 19, 2022
@alexstotsky alexstotsky deleted the win-loss-prev-day branch September 20, 2022 08:57
@ZIMkaRU ZIMkaRU mentioned this pull request Sep 21, 2022
Merged
@ezewer ezewer mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn