Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Notify users sync is being paused until connection is resumed #537

Merged
merged 5 commits into from
Aug 10, 2022
Merged

(feature) Notify users sync is being paused until connection is resumed #537

merged 5 commits into from
Aug 10, 2022

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Aug 9, 2022 •
edited
Loading

Task: Notify users when fetching data from bfx_api_v2 is paused due broken internet connection

Description:

  • Implements users notification when fetching data from bfx_api_v2 is paused due broken internet connection and also when the connection is resumed

Preview:

net_err

@alexstotsky alexstotsky marked this pull request as ready for review August 9, 2022 13:06
ezewer
ezewer approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit 497f732 into bitfinexcom:master Aug 10, 2022
@ZIMkaRU ZIMkaRU mentioned this pull request Aug 11, 2022
Merged
@ezewer ezewer mentioned this pull request Aug 11, 2022
Merged
@alexstotsky alexstotsky deleted the notify-net-err branch August 11, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @prdn