Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Selectable charts range values sum up #535

Merged
merged 29 commits into from
Aug 4, 2022
Merged

(feature) Selectable charts range values sum up #535

merged 29 commits into from
Aug 4, 2022

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Aug 3, 2022 •
edited
Loading

Task: Traded volume / fees sum up

Description:

  • Implements selectable charts area and Sum Up range values feature for the Traded Volume and Fees reports

Preview:

chart-range-sum-up-feat.mov

alexstotsky added 27 commits August 2, 2022 17:38
Implement chart selectable reference area
e4ead58
Prevent chart redrawing on area selection
405cc8e
Add custom tooltip styling
e11e459
[WIP]Charts custom tooltip
95a524f
Improve custom tooltip label styling
6c06e40
Implement mouse event handlers and dynamic tooltip types rendering
8649a94
Add sum up tooltip
a670fef
Improve charts data check and cleanup
168d37e
Update translations
9c4b659
Add formatSumUpValue chart helper
a4055eb
Improve sum tooltip title and label formatting, update prop-types
ee35cf5
Fix cartesian axis ticks flickering on mouse events
57e5a8b
Update mouse events handlers
eef485e
Add getSumUpRange helper
da3a9f5
Improve sum up tooltip
c7f6fef
Implement getSumUpRangeValue helper
1f59c7e
Update sum up title
54d1813
Improve reference area data handling
56db95d
Improve custom tooltip spacing and colors
813f319
Improve sum up label
1cc220f
Unused helper cleanup
5d2385c
Improve traded volume chart config
a48c2c0
Improve fees report sagas flow
4fbad83
Optimize reference area render and handlers
e84a338
Update fees report chart props
3c862fc
Improved traded volume sagas
6110e42
Update chart types/defaults
894b4c3
@alexstotsky alexstotsky marked this pull request as ready for review August 3, 2022 11:37
ezewer
ezewer approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit e7922d5 into bitfinexcom:master Aug 4, 2022
@alexstotsky alexstotsky deleted the fees-volume-sum-up branch August 5, 2022 10:44
@ZIMkaRU ZIMkaRU mentioned this pull request Aug 11, 2022
Merged
@ezewer ezewer mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvis-poggi elvis-poggi elvis-poggi approved these changes

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn