Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Refresh auth token when user re-login via WebSockets #532

Merged
merged 1 commit into from
Jul 27, 2022
Merged

(fix) Refresh auth token when user re-login via WebSockets #532

merged 1 commit into from
Jul 27, 2022

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Jul 26, 2022 •
edited
Loading

Task: Refresh auth token when user re-login via WebSockets

Description:

  • Adds auth refreshing on re-login via WebSockets and fixes issues with broken HTTP requests due to the staled token from the previous authorization

Before:

ws_signin_before_1

ws_signin_before_2

After:

ws_signin_after_1

ws_signin_after_2

@alexstotsky alexstotsky marked this pull request as ready for review July 26, 2022 12:20
ezewer
ezewer approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@prdn prdn merged commit e61eb5c into bitfinexcom:master Jul 27, 2022
@alexstotsky alexstotsky deleted the refresh-auth-via-ws branch July 29, 2022 08:58
This was referenced Aug 10, 2022
Merged
Merged
@ezewer ezewer mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @prdn