Memoize nav switcher and lint fixes

bitfinexcom · Jun 18, 2024 · 5360003 · 5360003
1 parent ce4363f
commit 5360003
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/ui/NavSwitcher/NavSwitcher.js b/src/ui/NavSwitcher/NavSwitcher.js
@@ -1,13 +1,16 @@
-import React from 'react'
+import React, { memo } from 'react'
 import PropTypes from 'prop-types'
 import classNames from 'classnames'
 import _map from 'lodash/map'
 import { isEqual } from '@bitfinex/lib-js-util-base'
 
 import { tracker } from 'utils/trackers'
 
-const NavSwitcher = (props) => {
-  const { items, onChange, value: activeItem } = props
+const NavSwitcher = ({
+  items,
+  onChange,
+  value: activeItem,
+}) => {
   const handleClick = (itemValue) => {
     tracker.trackEvent(itemValue, 'Tab')
     onChange(itemValue)
@@ -22,7 +25,11 @@ const NavSwitcher = (props) => {
         })
 
         return (
-          <span className={itemClasses} onClick={() => handleClick(itemValue)} key={itemValue}>
+          <span
+            key={itemValue}
+            className={itemClasses}
+            onClick={() => handleClick(itemValue)}
+          >
             {label}
           </span>
         )
@@ -40,4 +47,4 @@ NavSwitcher.propTypes = {
   value: PropTypes.string.isRequired,
 }
 
-export default NavSwitcher
+export default memo(NavSwitcher)