Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress perc to loading win for import-db module #449

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Add progress perc to loading win for import-db module #449

merged 6 commits into from
Nov 20, 2024

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Nov 19, 2024

This PR adds progress perc to the loading window for the import-db module as it can take significant time for large DB

There is no progress event available in the yauzl lib
We have to handle progress by getting data chunk length for each file stream

  • en:
    en-1
    en-2
    en-3

  • ru:
    ru-1
    ru-2
    ru-3

ezewer
ezewer approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit c55ff55 into bitfinexcom:staging Nov 20, 2024
@ZIMkaRU ZIMkaRU mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZIMkaRU @ezewer