Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend electron app wrapper translations #422

Merged

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Oct 18, 2024

This PR extends electron app wrapper translations, it's a part of the common task and here improves the app init error layout


Basic changes:

  • Fix logs collection for bug report
  • Improve app init to use translations in error layout
  • Add ability to use translations in browser windows
  • Add translations for app init error layout
  • Use translations in app init error layout
  • Fix zenity closing behavior for error modal win on Ubuntu. The context is if push close button in menu bar zenity will exit with 1 which will cause an error
  • Add ability to use app.exit() method in the browser window of app init error layout
  • Improve app init error layout

Example of the app init error layout:

Screenshot from 2024-10-17 13-35-36

Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 4ff543c into bitfinexcom:staging Oct 22, 2024
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants