Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dotenv importing for prod env #414

Merged

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Oct 4, 2024

This PR fixes dotenv importing for prod env


We use dotenv in electron-builder config file to build binaries and this dependency is in the dev section. It needs to exclude importing dotenv under prod env as we use that config file in the main code (not only for assembly), but dotenv is redundant here

Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt!

@ezewer ezewer merged commit 9371a7d into bitfinexcom:staging Oct 8, 2024
This was referenced Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants