Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show native notification for sync if processing with hidden main window #390

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Aug 9, 2024

This PR adds ability to show the native notification in the electron app in case the sync is being processed in the background with the hidden main window
There we check if the main window is invisible and show a notification otherwise don't


Example:

Screenshot from 2024-08-09 07-18-02

Copy link
Collaborator

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 3867172 into bitfinexcom:staging Aug 28, 2024
This was referenced Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants