Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions to use Nodejs v20 #323

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Feb 23, 2024

This PR updates GH Actions to use Nodejs v20


Context: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
Our current warnings: https://github.com/bitfinexcom/bfx-report-electron/actions/runs/7913595670

Screenshot from 2024-02-22 14-56-35


Basic changes:

  • Update gh actions to resolve deprecation warnings
  • Point coactions/setup-xvfb gh action to exact commit to have required nodejs ver under hood: resolved here Use node20 coactions/setup-xvfb#23
  • Fix disabling auto-update when build release. Minore improvement for beta releases

TODO:


Everything has been tested on own fork:

Copy link
Collaborator

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit 61c3dfc into bitfinexcom:staging Mar 4, 2024
@ZIMkaRU ZIMkaRU deleted the feature/optimize-github-workflow-for-release-build branch March 13, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants